Table

Started by AlexxanderX, 11 December 2015, 15:23:23

AlexxanderX

Sorry for late response. I will try it, but Monday, after all the feast past.

texus

The next tgui release is planned in February, so there's no rush :)

texus

Did you already found some time to look at my version?

AlexxanderX

So I made time to finish the table. Why would you want to combine the size function with the position function? I want to say that updateWidgetPosition() is pretty frequently called and would be useless, only if somehow check if the size changed. What I need to resolve? I will also add comments in order to explain what I do.

texus

The updateWidgetPosition will only be called when widgets are changed, which isn't that frequent. I only care about performance when something is called almost every frame, but this function is only called a lot while creating the table (while adding the rows). The setPosition and setSize functions of widgets will become very light operations in the near future so the function won't be that heavy.

The Table class on my bitbucket looks finished at first sight. So you don't really have to resolve anything unless you find things that are still missing. It juststill has to be extensively tested.

Zetal

#35
Quote from: texus on 15 January 2016, 13:49:38
The updateWidgetPosition will only be called when widgets are changed, which isn't that frequent. I only care about performance when something is called almost every frame, but this function is only called a lot while creating the table (while adding the rows). The setPosition and setSize functions of widgets will become very light operations in the near future so the function won't be that heavy.

The Table class on my bitbucket looks finished at first sight. So you don't really have to resolve anything unless you find things that are still missing. It juststill has to be extensively tested.

That BitBucket link isn't accessible for me, and I'm interested in using this Table class. Would it be possible for me to have access to these classes to save me the time remaking it? Thanks!

Edit: Nevermind! I found that this was "reimplemented" as a ListView in this commit: https://github.com/texus/TGUI/commit/54e72fbdcf038bb9f614ffb1219074c6221ac8d4